Add DSS integration tests for CPU and NVIDIA GPU (New) #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motjuste
force-pushed
the
CHECKBOX-1667-add-dss-integration-tests
branch
3 times, most recently
from
bca6355 to
f558eb1
Compare
motjuste
force-pushed
the
CHECKBOX-1667-add-dss-integration-tests
branch
from
f558eb1 to
9dd778a
Compare
pieqq
requested changes
Dec 6, 2024
contrib/checkbox-dss-validation/checkbox-provider-dss/units/jobs.pxu
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/units/jobs.pxu
Outdated
Show resolved
Hide resolved
contrib/checkbox-dss-validation/checkbox-provider-dss/units/test-plan.pxu
Show resolved
Hide resolved
this is to catch situations where the script is called with unsupported arguments.
|
The tests have been re-triggered: https://github.com/canonical/checkbox/actions/runs/12201552963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added integration tests from the
data-science-stackrepo. These tests need to be run at the very end, and require that DSS is not initialized, because the integration tests themselves initialize and purge DSS and check for relevant success. Integration tests for NVIDIA GPU also require that the relevant k8s plugin is setup.The Git repo is cloned, the relevant virtual environment is created, and the tests are executed using
toxfrom the virtual environment.Resolved issues
Documentation
There are no changes to the documentation.
Tests
The relevant DSS workflow run: https://github.com/canonical/checkbox/actions/runs/12143951564
to save ourselves some time...
The job linked above was actually run on a different branch, which consists of commits from this PR, and PR #1634 together. This is because the workflow runs can take a very long time, and while their changes don't overlap, the two PRs are worth testing together.
The failures on testing DSS latest/edge are expected due to a reported issue and do not stem from these changes to Checkbox. The one failure testing DSS latest/stable is during provisioning from Testflinger, before the Checkbox validations are even installed.